BUG Report: Broken Find/Replace

[Aaron]

Thanks for the detailed, report. I have reproduced this and will make a tracker entry.

Thanks for catching that, and providing such detailed steps to reproduce it.

[Brian]

Find/Replace still is slightly broken.

Enter the text string ("|" indicates cursor):

2|22
222

Do standard find/replace, replacing "22" with "3". Choose "Replace All."

If "Wrap Search" is off, it functions as expected, returning:
23
32

If "Wrap Search" is on, it instead returns:
32
32


A similar bug occurs when searching with "Search up" (regardless of whether "Wrap Search" is checked. Using the search below:

222
222|

It should return:
23
23

but instead returns
32
32

Note that this issue also occurs when using "Replace." I find it interesting that replace with "Search up" correctly reads from right to left when searching 2222 but not when searching 222.

Unlike the original issue, this issue is rather minor. Overlapping searches of this type are probably not overly common and it is not leaving extraneous characters in place, just picking the wrong replacement order.

[Aaron]

Thanks for the report. I was able to reproduce this and I'll make a tracker entry for our developers to investigate.

Thanks, again, for the detailed test case. That helped a great deal.

[Brian]

Tested on 3.1.11 (build 12204)

Steps to reproduce:

Paste the below text into the left or right comparison window
File Text:

ABCDEFABCDEF

Click between the first F and the 2nd A. The window will look like this, with a pipe, '|', indicating the cursor:

ABCDEF|ABCDEF

Hit CTRL+H.

Fill in the form as follows:
Text to find: ABCDEF
Replace with: G
Options selected: Match character case, Wrap search, Left.

Click "Replace All"

Output:
GABCDEG

Expected Output:
GG